docs: updated Azure AD instructions for user management#10216
Closed
schakko wants to merge 2 commits intoargoproj:masterfrom
Closed
docs: updated Azure AD instructions for user management#10216schakko wants to merge 2 commits intoargoproj:masterfrom
schakko wants to merge 2 commits intoargoproj:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10216 +/- ##
=======================================
Coverage 45.64% 45.64%
=======================================
Files 239 239
Lines 28991 28991
=======================================
Hits 13233 13233
Misses 13939 13939
Partials 1819 1819 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
requested changes
Aug 5, 2022
Member
crenshaw-dev
left a comment
crenshaw-dev
left a comment
There was a problem hiding this comment.
Thanks @schakko! One top-level commend, then I'll come back for a more thorough review. :-)
schakko
force-pushed
the
docs/update-instructions-for-microsoft-azure-ad
branch
from
f010821 to
829cf1c
Compare
crenshaw-dev
requested changes
Aug 8, 2022
Member
crenshaw-dev
left a comment
crenshaw-dev
left a comment
There was a problem hiding this comment.
Just a few more nitpicks. Otherwise LGTM. :-)
10 tasks
schakko
force-pushed
the
docs/update-instructions-for-microsoft-azure-ad
branch
2 times, most recently
from
e995f2e to
f16f45b
Compare
* moved RBAC to its own section to prevent duplicate content
* added scenario for mapping security groups to RBAC roles
* added scenario for mapping application roles to RBAC roles
* fixed indention of `scope` YAML key
* fixed product naming ("Argo CD" w/ whitespaces)
Signed-off-by: Christopher Klein <ckl@dreitier.com>
schakko
force-pushed
the
docs/update-instructions-for-microsoft-azure-ad
branch
from
f16f45b to
8e8a0b1
Compare
…re-ad Signed-off-by: Schakko <schakkonator@googlemail.com>
Member
|
This is pretty old, and there have been updates to the Azure AD (or Entra ID?) since. If there is anything that's still relevant to add, could you open a new PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current documentation for setting up the Azure AD user management integration contains duplicate content and misses some instructions.
Content of this PR:
scopeYAML keySigned-off-by: Christopher Klein ckl@dreitier.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: